feat: added trends breakdown by cohort #18028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilbert09
changed the title
|
Hey @Gilbert09! 👋 |
mariusandra
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Cool and makes sense to me. Speaking of cohorts though, there's a PR out that changes their behaviour just a bit. Hopefully this will keep on working
daibhin
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Fixed missing param when building Breakdown * Added support for breakdowns with hogql expressions * Added trends breakdown by cohort * Remove None valued keys from the filter obj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
nqueries, wherenis the count of cohorts selected in the frontend. This is due to the HogQL joins of Cohorts not returning the cohort ID, which is required when selecting the multiple series from the clickhouse results, thus having to inject the cohort ID at query time instead on a per-query basisHow did you test this code?